Preserve existing dylib paths before calling spirv-builder#61
Merged
LegNeato merged 1 commit intoRust-GPU:mainfrom Mar 30, 2025
Merged
Preserve existing dylib paths before calling spirv-builder#61LegNeato merged 1 commit intoRust-GPU:mainfrom
LegNeato merged 1 commit intoRust-GPU:mainfrom
Conversation
Collaborator
|
Great find @bspeice! So does this PR fix the issue you mentioned in your comment? My only thought about this PR was whether each of the other platform ENV vars were also lists, and it looks like they are.
So I approve this PR too ✅ |
Contributor
Author
|
@tombh - yes, this resolves the "spirv-builder can't find cargo" issue in my comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #20,
spirv-builder-clisets up the environment to loadrustc_codegen_spirv, but does so without preserving existing paths. Becausespirv-builder-clisets thePATHvariable on Windows,spirv-builderis then unable to find thecargocommand, causing the issues seen in #50.Instead, prepend the necessary paths so
spirv-buildercan findcargo.