Ran cargo fmt + added some .context() calls for non-obvious errors#56
Ran cargo fmt + added some .context() calls for non-obvious errors#56LegNeato merged 8 commits intoRust-GPU:mainfrom
cargo fmt + added some .context() calls for non-obvious errors#56Conversation
|
Oh nice! I see we already have a |
|
hmmm noo I don't think so... it'd have to be in ~/rustfmt.toml right? |
|
ahh but now the imports didn't change back |
|
@tombh all right I think it's ready for review |
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
Thank you! Just a few little nits and then I think we're ready to merge.
|
|
||
| use crate::{install::Install, target_spec_dir}; | ||
| use spirv_builder_cli::{args::BuildArgs, Linkage, ShaderModule}; | ||
|
|
There was a problem hiding this comment.
Was this removed by auto formatting?
crates/cargo-gpu/src/install.rs
Outdated
| @@ -1,4 +1,5 @@ | |||
| //! Install a dedicated per-shader crate that has the `rust-gpu` compiler in it. | |||
| //! | |||
There was a problem hiding this comment.
This should be a blank line, instead of a blank comment.
crates/cargo-gpu/src/install.rs
Outdated
| let mut file = std::fs::File::create(&path) | ||
| .with_context(|| format!("creating file at [{}]", path.display()))?; | ||
| file.write_all(contents.as_bytes()) | ||
| .context("writring to file")?; |
crates/cargo-gpu/src/install.rs
Outdated
| .context("getting command output") | ||
| .and_then(|output| { | ||
| log::trace!("STDOUT:\n{}", String::from_utf8_lossy(&output.stdout)); | ||
| log::trace!("STDERR:\n{}", String::from_utf8_lossy(&output.stderr)); |
There was a problem hiding this comment.
These lines shouldn't be necessary, since the command inherits stdin and stdout, right? Maybe I'm missing something though.
|
Thanks @Niedzwiedzw - just waiting for the CI checks and then I'll merge 👍 . |
4 participants
No description provided.