add manifest-file configuration option to BuildArgs#51
Merged
schell merged 1 commit intoRust-GPU:mainfrom Feb 28, 2025
Merged
Conversation
schell
reviewed
Feb 27, 2025
schell
approved these changes
Feb 27, 2025
Collaborator
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
Good idea! Thanks for the contribution :)
SiebenCorgie
force-pushed
the
feature-rename-manifest
branch
from
c87be19 to
d85dd2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to the
BuildArgsto rename mainfest files. The default case staysmanifest.json.Currently, the name is hardcoded to manifest.json, which becomes a problem when you collect all your SPIR-V fragments in one place. This way you can still use manifest files to parse your entrypoints.