Fixes to the Optix crate #157
Open
+22
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note you are going to want to rebase on #156 as it touches a ton of stuff. |
|
(it's just about ready to land) |
|
Gotcha, will do! Thanks for letting me know. I'll keep this open and rebase on top once that drops, if that works |
Schmiedium
force-pushed
the
fix_optix_compile_errors
branch
from
5dfb476 to
7e7007d
Compare
|
Rebased on top of the recent changes from #156, checked that everything still works |
LegNeato
requested changes
Mar 13, 2025
frjnn
approved these changes
Mar 13, 2025
|
Understood, I can reorganize that and push up the changes shortly. I can work on documenting the rest of them as well, that might take a minute as I figure out the specifics of what they do. Thanks for reviewing! |
…stead of the impl block
|
looks like this overlaps with #159 |
|
Okay, should I close this one out then? I'd prefer not to duplicate work in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new traits needed to be derived for MotionFlags, InstanceFlags, and some others. Additonally, from here: https://docs.rs/bitflags/latest/bitflags/, it looks we need to use the impl syntax for the bit flag structs to work with the custom derive macros from cust.
Also fixed a warning about an elided lifetime