gccrs: add overlapping range endpoints lint#4642
Open
lucasly-ba wants to merge 1 commit into
Open
Conversation
lucasly-ba
force-pushed
the
overlapping-range-endpoints
branch
2 times, most recently
from
fe72bca to
b8f244f
Compare
Collaborator
|
It looks like these range checks are |
Collaborator
|
Actually, it looks like your changelog needs some tweaks. It should only mention the test you added and your changes to |
lucasly-ba
force-pushed
the
overlapping-range-endpoints
branch
2 times, most recently
from
4581dc1 to
a18328d
Compare
Warn when two range patterns in a match overlap on a single endpoint, for example `0..=5` and `5..=10` which both match `5`. gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit(HIR::MatchExpr)): Warn on overlapping range endpoints. * rust-lang.cc (grs_langhook_init_options_struct): Enable warn_unused. gcc/testsuite/ChangeLog: * rust/compile/overlapping-range-endpoints_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
lucasly-ba
force-pushed
the
overlapping-range-endpoints
branch
from
a18328d to
4f77d72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the overlapping range endpoints lint, which warns when two range patterns in a match overlap on a single endpoint, for example
0..=5and5..=10(both match5).gcc/testsuite/ChangeLog: