nr2.0: Run a final TopLevel pass after desugaring
#3801
Conversation
gcc/rust/rust-session-manager.cc
Outdated
| @@ -622,6 +622,14 @@ Session::compile_crate (const char *filename) | |||
| AST::DesugarQuestionMark ().go (parsed_crate); | |||
| AST::DesugarApit ().go (parsed_crate); | |||
|
|
|||
| // HACK: run a final toplevel pass | |||
| // since desugaring may have added definitions | |||
| if (!saw_errors () && flag_name_resolution_2_0) | |||
There was a problem hiding this comment.
Shouldn't we also run early nr again since some of those definitions could technically be matched to some invocations ?
If we could make macro fixed point more generic that would allow us to avoid this weird top level nr call.
There was a problem hiding this comment.
I was thinking we'd be done with early resolution before the desugaring and would only need to run TopLevel for the benefit of Late resolution.
|
I don't know if this is the best way to go about this, it's definitely hacky. maybe we could do all the desugars as part of the fixed point and mark the visitor as dirty when we find something to desugar |
This fixes some issues with name resolution 2.0. gcc/rust/ChangeLog: * rust-session-manager.cc (Session::compile_crate): Move AST desugaring to... (Session::expansion): ...here and add a final TopLevel pass afterwards. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove entries. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
It looks like doing exactly that would screw up |
No description provided.