New class for bck diagnostics #3076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkm
reviewed
Jul 5, 2024
.github/workflows/ccpp.yml
Outdated
Comment on lines
42
to
45
| dejagnu; | ||
| # install Rust directly using rustup | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=1.72.0; | ||
| curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain=nightly; |
There was a problem hiding this comment.
I'm curious. Why do we need to use nightly instead of latest stable?
There was a problem hiding this comment.
because I needed to use rust extern types (opaque types) here
its an ustable feature, so not supported in stable rust currently
braw-lee
force-pushed
the
add_bck_diagnostic_class
branch
from
1151776 to
4d3df76
Compare
CohenArthur
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
the class looks good! good idea! we'll merge #3058 and then this one :)
gcc/rust/ChangeLog: * Make-lang.in: Compile new file. * checks/errors/borrowck/rust-borrow-checker.cc (BorrowChecker::go): Use new class to report errors. * checks/errors/borrowck/rust-borrow-checker-diagnostics.cc: New file. * checks/errors/borrowck/rust-borrow-checker-diagnostics.h: New file, adds new class. Signed-off-by: Kushal Pal <kushalpal109@gmail.com>
braw-lee
force-pushed
the
add_bck_diagnostic_class
branch
from
4d3df76 to
e5e6c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will handle borrow-checking diagnostics inside this class
depends on #3058