Skip to content

Commit

Permalink
[Lint] Disable modernize-use-override (ray-project#19368)
Browse files Browse the repository at this point in the history
This lint rule cannot apply only to changed lines because currently Ray has `-Winconsistent-missing-override` as a build flag. Either all or none of member functions from a derived class can have the `override` / `final` annocation.
  • Loading branch information
mwtian authored Oct 14, 2021
1 parent 5cee8a1 commit 1210001
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# -modernize-use-emplace (more subtle behavior)
# -modernize-use-nodiscard (too much noise)
# -modernize-use-trailing-return-type (inconsistent style)
# -modernize-use-override (TODO(mwtian): re-enable after fixing existing derived classes)
# -modernize-avoid-bind (incorrect conversion)
# -modernize-loop-convert (more subtle behavior)
# -modernize-replace-disallow-copy-and-assign-macro (inconsistent style)
Expand Down Expand Up @@ -42,6 +43,7 @@ Checks: >
-modernize-replace-disallow-copy-and-assign-macro,
-modernize-make-unique,
-modernize-make-shared,
-modernize-use-override,
performance-*,
readability-avoid-const-params-in-decls,
readability-braces-around-statements,
Expand Down

0 comments on commit 1210001

Please sign in to comment.