release: v1.2.6+node24.14.1 into maintenance/v1+node24#94
Merged
Amnoor merged 6 commits intomaintenance/v1+node24from Apr 4, 2026
Merged
release: v1.2.6+node24.14.1 into maintenance/v1+node24#94Amnoor merged 6 commits intomaintenance/v1+node24from
Amnoor merged 6 commits intomaintenance/v1+node24from
Conversation
…de24" branch
This merge updates `.github/workflows/pr-tests.yml` on the `develop-v1+node24` line to stop pushing PR test images to Docker Hub and instead pass the built image between jobs as an OCI artifact. The test workflow now uploads the multi-arch build output from `build-image`, downloads it in `test-image`, extracts a per-architecture image into the local Docker daemon with `skopeo`, and removes the artifact after testing. The artifact name includes the pull request number so concurrent PR runs do not share the same artifact identifier.
In `build-image`, the `Login to Docker Hub` step is removed and the `Build Image` step changes from `push: true` to `push: false` with `outputs: type=oci,dest=image.tar`, so the workflow produces a local OCI archive instead of publishing a PR image to Docker Hub. A new `Upload Docker Image Artifact` step uses `actions/upload-artifact@v4` to persist `image.tar` as `docker-image-pr-${{ github.event.pull_request.number }}`. In `test-image`, the Docker Hub login and `docker pull` flow are removed, `TEST_IMAGE` changes from `runtimenode/test:pr-${{ github.event.pull_request.number }}` to `test:pr-${{ github.event.pull_request.number }}`, and new `Download Docker Image Artifact` and `Extract single-arch image with Skopeo` steps load each matrix entry’s `linux/amd64` or `linux/arm64` image as `test:pr-<number>-<arch>`. The smoke test and all integrity checks are updated to resolve `${{ matrix.platform }}` into `ARCH` and run against `${{ env.TEST_IMAGE }}-$ARCH` so they validate the locally extracted per-architecture image. A new `artifact-clean-up` job then removes `docker-image-pr-${{ github.event.pull_request.number }}` using `geekyeggo/delete-artifact@v4` after testing completes.
No other files or workflow jobs are modified by this merge.
…e24" branch This merge updates `README.md` on the `develop-v1+node24` line so the documentation reflects the upcoming `v1.2.6+node24.14.1` maintenance release and the current CI/CD tooling used by the repository. It refreshes the versioning examples in the Versioning and Tags section and expands the acknowledgements so the current validation artifact and deployment-tracking actions are documented alongside the existing workflow tooling. In `README.md`, the Versioning and Tags example is updated from `v1.2.4+node24.14.1` to `v1.2.6+node24.14.1`. The `docker/metadata-action` normalization note is also updated from `v1.2.4+node24.14.1` → `v1.2.4-node24.14.1` to `v1.2.6+node24.14.1` → `v1.2.6-node24.14.1`. The `CI/CD & Build Tooling` section is expanded to add `actions/upload-artifact`, `actions/download-artifact`, and `geekyeggo/delete-artifact` for the PR test artifact workflow, plus `chrnorm/deployment-action` and `chrnorm/deployment-status` for GitHub Deployment tracking in the release workflow. No other files or documentation sections are modified by this merge.
…p-v1+node24" branch This merge updates the GitHub Actions workflows on the `develop-v1+node24` line to use `docker/build-push-action@v7` instead of the current older major versions. It applies the version bump in both `.github/workflows/deployment.yml` and `.github/workflows/pr-tests.yml` while keeping the existing attestation, artifact, cache, and validation logic unchanged. In `.github/workflows/deployment.yml`, the `Build and push (multi-registry, multi-platform)` step is updated from `uses: docker/build-push-action@v5` to `uses: docker/build-push-action@v7` without changing the existing `attests:`, tag, label, platform, or cache settings. In `.github/workflows/pr-tests.yml`, the `Build Image` step is updated from `uses: docker/build-push-action@v6` to `uses: docker/build-push-action@v7` without changing the existing OCI archive output, multi-platform build, tag, artifact, or cache configuration. No other files or workflow jobs are modified by this merge.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR promotes
release/v1.2.6+node24.14.1intomaintenance/v1+node24, marking the next patch release on the Node.js 24 maintenance line. It consolidates three development cycles: the PR test workflow move from Docker Hub-pushed images to OCI artifact handoff, thedocker/build-push-actionupgrade tov7in both workflows, and README updates aligning the versioning examples and CI/CD tooling references with the current v1 maintenance release state. The Node.js runtime remains24.14.1.Files Changed
Added:
Modified:
README.md.github/workflows/deployment.ymlpr-tests.ymlDeleted:
Key Changes
.github/workflows/pr-tests.ymlto stop pushing PR images to Docker Hub by changing theBuild Imagestep frompush: truetopush: falsewithoutputs: type=oci,dest=image.tar, addingUpload Docker Image Artifact,Download Docker Image Artifact,Extract single-arch image with Skopeo, andartifact-clean-up, and changing the test image flow to local per-architecture images derived from the OCI artifact..github/workflows/pr-tests.ymlfromuses: docker/build-push-action@v6touses: docker/build-push-action@v7in theBuild Imagestep, and updated.github/workflows/deployment.ymlfromuses: docker/build-push-action@v5touses: docker/build-push-action@v7in theBuild and push (multi-registry, multi-platform)step.README.mdfromv1.2.4+node24.14.1tov1.2.6+node24.14.1, updated thedocker/metadata-actionnormalization note fromv1.2.4+node24.14.1→v1.2.4-node24.14.1tov1.2.6+node24.14.1→v1.2.6-node24.14.1, and addedactions/upload-artifact,actions/download-artifact,geekyeggo/delete-artifact,chrnorm/deployment-action, andchrnorm/deployment-statusto theCI/CD & Build Toolingsection ofREADME.md.