Skip to content

release: v1.2.5+node24.14.1 into maintenance/v1+node24#82

Merged
Amnoor merged 2 commits intomaintenance/v1+node24from
release/v1.2.5+node24.14.1
Apr 2, 2026
Merged

release: v1.2.5+node24.14.1 into maintenance/v1+node24#82
Amnoor merged 2 commits intomaintenance/v1+node24from
release/v1.2.5+node24.14.1

Conversation

@Amnoor
Copy link
Copy Markdown
Member

@Amnoor Amnoor commented Apr 2, 2026

Summary

This PR promotes
elease/v1.2.5+node24.14.1 into maintenance/v1+node24, marking the next patch release on the Node.js 24 maintenance line. It consolidates one deployment workflow update in .github/workflows/deployment.yml that grants the release job the OIDC permission needed for signed BuildKit attestations and switches the multi-platform build step to explicit �ttests: entries with mode=max. The Node.js runtime remains 24.14.1.

Files Changed

Added:

  • None

Modified:

  • .github/
    • workflows/
      • deployment.yml

Deleted:

  • None

Key Changes

  • Added id-token: write to the top-level permissions: block in .github/workflows/deployment.yml so the release workflow can mint the OIDC token required for signed BuildKit attestations.
  • Replaced provenance: true with �ttests: entry ype=provenance,mode=max in the Build and push (multi-registry, multi-platform) step of .github/workflows/deployment.yml so provenance attestations are emitted with maximum detail.
  • Replaced sbom: true with �ttests: entry ype=sbom,mode=max in the Build and push (multi-registry, multi-platform) step of .github/workflows/deployment.yml so SBOM attestations are emitted with maximum detail.

Amnoor and others added 2 commits April 2, 2026 19:42
…velop-v1+node24" branch

This merge updates `.github/workflows/deployment.yml` on the `develop-v1+node24` line to grant the release workflow the permissions needed for signed BuildKit attestations and to switch the image build step from boolean provenance and SBOM flags to explicit `attests:` entries. The release build now requests `mode=max` provenance and SBOM attestations so published images carry the full attestation payload supported by BuildKit.

In the top-level `permissions:` block, the workflow now adds `id-token: write` so the job can mint the OIDC token required for attestation signing. In the `Build and push (multi-registry, multi-platform)` step, `provenance: true` is replaced with `attests:` entry `type=provenance,mode=max`, and `sbom: true` is replaced with `attests:` entry `type=sbom,mode=max`, leaving the rest of the build configuration unchanged.

No other files or workflow jobs are modified by this merge.
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@Amnoor Amnoor merged commit 07eced2 into maintenance/v1+node24 Apr 2, 2026
4 checks passed
@Amnoor Amnoor deleted the release/v1.2.5+node24.14.1 branch April 2, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant