Skip to content

fixed appmetrics dependencies #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed appmetrics dependencies #29

wants to merge 1 commit into from

Conversation

xlazex
Copy link

@xlazex xlazex commented Sep 1, 2017 •
edited
Loading

FIXES this error:

Unsupported version v8.4.0. Exiting.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! appmetrics@1.2.0 install: node extract_all_binaries.js
npm ERR! Exit status 1

fixed appmetrics dependencies
49b18ca 
FIXES this error:
________
Unsupported version v8.4.0. Exiting.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! appmetrics@1.2.0 install: `node extract_all_binaries.js`
npm ERR! Exit status 1
sam-github
sam-github approved these changes Sep 1, 2017
View reviewed changes
Copy link

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks (we should review all the appmetrics-* addons for this).

I don't think this kind of trivial change requires a CLA - does it @sjanuary @stalleyj ?

ggb667
ggb667 approved these changes Jan 8, 2018
View reviewed changes
Copy link

@ggb667 ggb667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@sam-github sam-github sam-github approved these changes

@ggb667 ggb667 ggb667 approved these changes

@mohitbhansali mohitbhansali mohitbhansali approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xlazex @sam-github @ggb667 @mohitbhansali