Remove SwiftyJSON #191
Remove SwiftyJSON #191
Conversation
ShihabMehboob
force-pushed
the
remove-swiftyjson
branch
from
ee39f10 to
e631d6a
Compare
|
@ShihabMehboob could you rebase this PR please? You seem to have some of Jonathan's changes in the diff that have already been merged into master. Has this been tested on Bluemix to check that the autoscaling agent is still getting the right data from us? |
|
The app has been tested on Bluemix/IBM Cloud, and attached to the autoscaling service, displaying data as seen in the screenshot of the dashboard data. |
AUTHORS.md
Outdated
| - Toby Corbin (https://github.com/tobespc) | ||
| - Julie Stalley (https://github.com/stalleyj) | ||
| - Navneet Gupta (https://github.com/na-gupta) | ||
| - Ricardo Olivieri (https://github.com/rolivieri) | ||
| - qibobo (https://github.com/qibobo) | ||
| - Sian January (https://github.com/sjanuary) | ||
| - Kye Maloy (https://github.com/kyemaloy97) | ||
| - Jonathan Spruce (https://github.com/jonathan-spruce) |
There was a problem hiding this comment.
Shouldn't this be adding your name, not Jonathan's?
| var metricsConfig: String | ||
| var reportInterval: Int | ||
|
|
||
| public enum CodingKeys: String, CodingKey { |
There was a problem hiding this comment.
As these CodingKeys don't change the name of any of the keys, can we remove the enum and let the compiler synthesise it?
|
@ShihabMehboob have you re-tested on Bluemix after making the changes that Ian asked for? If so I'm happy to get this merged in. |
|
|
This aims to replace SwiftyJSON with Codable.