WIP - Remove deprecation, reduce fluxnode undo database size, add new bench… #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w2vy
approved these changes
Dec 14, 2024
|
Regarding the discard greater than 500 blocks. What was the rationale behind only keeping 500? It seems kind of arbitrary? Please forgive me if I'm wrong here. (and disregard) Wouldn't that mean in the unlikely event that there was an issue with the chain and we need to roll back, we have to do it within 500 blocks or lose data? Isn't that a really small window? I would imagine the data required for storage increase between 500 blocks worth and say 2160 (3 days) would be negligble? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add new benchmarking key before merging.