Should meet requirements from Obsidian Review

Moved styles to CSS, replaced a cast with instanceof and reduced the amount of any use

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.0.3
+
+-   Behind the scenes improvements to streamline the codebase
+
 ## 1.0.2
 
 -   Updated manifest version number

manifest.json

@@ -1,7 +1,7 @@
 {
 	"id": "structured-tree",
 	"name": "Structured Tree",
-	"version": "1.0.2",
+	"version": "1.0.3",
 	"minAppVersion": "0.15.0",
 	"description": "A file explorer for navigating hierarchical notes separated by '.'",
 	"author": "Marius Svarverud",

src/custom-resolver/link-live.ts

@@ -56,6 +56,11 @@ class LinkWidget extends WidgetType {
   }
 }
 
+interface DecorationValue {
+  isReplace: boolean;
+  // Include other properties as needed
+}
+
 interface LinkData {
   start: number;
   end: number;
@@ -135,7 +140,8 @@ export class LinkLivePlugin implements PluginValue {
 
       let found = false;
       while (iter.value) {
-        if ((iter.value as any).isReplace) {
+        const decorValue = iter.value as DecorationValue | Decoration;
+        if ("isReplace" in decorValue && decorValue.isReplace) {
           const link = links.find(({ start }) => start === iter.from);
           if (link) {
             found = true;

src/modal/add-vault.ts

@@ -24,7 +24,12 @@ class FolderSuggester extends PopoverSuggest<TFolder> {
     this.suggestions.setSuggestions(suggestionList);
     this.open();
     this.setAutoDestroy(this.inputEl);
-    this.suggestEl.style.width = `${this.inputEl.offsetWidth}px`;
+
+    // Ensure the class is added
+    this.suggestEl.classList.add("suggestion-width-dynamic");
+    // Update the custom property with the current input element's width
+    this.suggestEl.style.setProperty('--suggestion-width', `${this.inputEl.offsetWidth}px`);
+
     const loc = this.inputEl.getBoundingClientRect();
     this.reposition({
       left: loc.left,
@@ -33,13 +38,11 @@ class FolderSuggester extends PopoverSuggest<TFolder> {
       bottom: loc.top + this.inputEl.offsetHeight,
     });
   };
-  getSuggestions(query: string) {
+  getSuggestions(query: string): TFolder[] {
     const queryLowercase = query.toLowerCase();
     return this.app.vault
       .getAllLoadedFiles()
-      .filter(
-        (file) => file instanceof TFolder && file.path.toLowerCase().contains(queryLowercase)
-      ) as TFolder[];
+      .filter((file): file is TFolder => file instanceof TFolder && file.path.toLowerCase().includes(queryLowercase));
   }
   renderSuggestion(value: TFolder, el: HTMLElement): void {
     el.createDiv({

styles.css

@@ -19,3 +19,7 @@
 .dendron-folder-suggest .suggestion-item {
   word-break: break-all;
 }
+
+.suggestion-width-dynamic {
+  width: var(--suggestion-width);
+}