Skip to content

Fix bit as valid datatype #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinburchell merged 3 commits into from
Mar 8, 2025
Merged

Fix bit as valid datatype #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e937fc3
Reinstate BIT and friends as valid datatypes
martinburchell Mar 7, 2025
3e7910b
Also add BIT to SQLTYPES_NOT_TEXT and SQLTYPES_NUMERIC
martinburchell Mar 8, 2025
acb839e
Update changelog
martinburchell Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cardinal_pythonlib/sql/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@
SQLTYPES_ALL = (
SQLTYPES_INTEGER
+ SQLTYPES_FLOAT
+ SQLTYPES_BIT
+ SQLTYPES_OTHER_NUMERIC
+ SQLTYPES_TEXT
+ SQLTYPES_BINARY
Expand All @@ -221,11 +222,14 @@
SQLTYPES_NOT_TEXT = (
SQLTYPES_INTEGER
+ SQLTYPES_FLOAT
+ SQLTYPES_BIT
+ SQLTYPES_OTHER_NUMERIC
+ SQLTYPES_DATETIME_ALL
+ SQLTYPES_OTHER
)
SQLTYPES_NUMERIC = SQLTYPES_INTEGER + SQLTYPES_FLOAT + SQLTYPES_OTHER_NUMERIC
SQLTYPES_NUMERIC = (
SQLTYPES_INTEGER + SQLTYPES_FLOAT + SQLTYPES_BIT + SQLTYPES_OTHER_NUMERIC
)


# =============================================================================
Expand Down
8 changes: 7 additions & 1 deletion docs/source/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ Quick links:
- :ref:`2022 <changelog_2022>`
- :ref:`2023 <changelog_2023>`
- :ref:`2024 <changelog_2024>`
- :ref:`2025 <changelog_2025>`


.. _changelog_2017:
Expand Down Expand Up @@ -853,7 +854,7 @@ Quick links:
were executing unconditionally, regardless of SQLAlchemy dialect (they should
have been conditional to SQL Server).

**2.0.2**
**2.0.2 (2025-03-06)**

- Bugfix to
:func:`cardinal_pythonlib.sqlalchemy.alembic_func.get_current_revision` where
Expand All @@ -871,3 +872,8 @@ Quick links:
default table dependency order and calculate another.

- Improve ability of Alembic support code to take a database URL.

**2.0.3**

- Reinstate BIT and similar datatypes in the list of valid datatypes. Broken
since v2.0.0.