Close connection after retrieving the current alembic version

[martinburchell]

Since the upgrade to SQLAlchemy 2.0, CamCOPS upgrade_db was hanging when upgrading the database. This appears to be due to this open connection causing a metadata lock.

[martinburchell]

@RudolfCardinal the test failures are because of this:

cardinal_pythonlib/sqlalchemy/tests/schema_tests.py:314: in <genexpr>
    col._make_proxy(t) for col in selectable.selected_columns
E   TypeError: Label._make_proxy() missing 2 required keyword-only arguments: 'primary_key' and 'foreign_keys'

since SQLAlchemy 2.0.38 i.e. unrelated to this change.

I can make the tests pass if I delete the call to _populate_separate_keys() . This line has been there from whenever that code was first written. Can you remember what this code was doing?

[RudolfCardinal]

Hmm. The use of "git blame" suggests you ;) I suspect it is a recipe from sqlalchemy/sqlalchemy#7779 . But that was a modification to something at https://github.com/sqlalchemy/sqlalchemy/wiki/Views , which itself was updated recently, for SQLAlchemy 2.0.38. So perhaps the current view recipe, which doesn't use the "internals", is the way to go?

[martinburchell]

Hmm. The use of "git blame" suggests you ;) I suspect it is a recipe from sqlalchemy/sqlalchemy#7779 . But that was a modification to something at https://github.com/sqlalchemy/sqlalchemy/wiki/Views , which itself was updated recently, for SQLAlchemy 2.0.38. So perhaps the current view recipe, which doesn't use the "internals", is the way to go?

Oh yes :) sorry! I have no memory of writing that. I am getting old. I will take a look at it.