Skip to content

Fix DDL non-conditionality re SQL Server#25

Merged
martinburchell merged 2 commits intomasterfrom
sqlalchemy_ddl_dialect_conditional
Jan 23, 2025
Merged

Fix DDL non-conditionality re SQL Server#25
martinburchell merged 2 commits intomasterfrom
sqlalchemy_ddl_dialect_conditional

Conversation

@RudolfCardinal
Copy link
Owner

No description provided.

@RudolfCardinal
Copy link
Owner Author

RudolfCardinal commented Jan 22, 2025

One test requires Python 3.10+ to run (because it uses unittest.TestCase.assertNoLogs). But it runs successfully on Python 3.10. Below that version, it will warn but pass.

@martinburchell
Copy link
Collaborator

Looks good to me and tested OK with CamCOPS, at least with MySQL.

There's some Python < 3.10 workarounds for assertNoLogs() discussed at https://stackoverflow.com/questions/35871815/python-3-unit-testing-assert-logger-not-called and I think we can live without the test for Python 3.9. I'm also wary of tests that assert nothing happens but in this case we do have the "something happens" test alongside it so if someone removed the message at least one of the tests would break.

@martinburchell martinburchell merged commit c97edc5 into master Jan 23, 2025
5 checks passed
@martinburchell martinburchell deleted the sqlalchemy_ddl_dialect_conditional branch January 23, 2025 16:27
@RudolfCardinal RudolfCardinal restored the sqlalchemy_ddl_dialect_conditional branch February 18, 2025 17:05
@RudolfCardinal RudolfCardinal deleted the sqlalchemy_ddl_dialect_conditional branch February 19, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants