Skip to content

Fix Bahraini dinar symbol - #958

Merged
antstorm merged 3 commits into
RubyMoney:masterfrom
satnami:hotfix/bahraini-dinar-symbol
Nov 26, 2020
Merged

antstorm merged 3 commits into
RubyMoney:masterfrom
satnami:hotfix/bahraini-dinar-symbol

Conversation

@satnami

@satnami satnami commented Nov 16, 2020 •

Copy link
Copy Markdown
Contributor

Issue #957 - According to the ISO-4217 and Bahraini dinar Wiki and Bahraini dinar Ar Wiki the correct currency symbol for this Bahraini Dinar should be د.ب instead of ب.د

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 99.865% when pulling e35c21d on satnami:hotfix/bahraini-dinar-symbol into 399d65f on RubyMoney:master.

@coveralls

coveralls commented Nov 16, 2020 •

Copy link
Copy Markdown

Coverage Status

Coverage increased (+9.0e-05%) to 99.863% when pulling cb2d9d2 on satnami:hotfix/bahraini-dinar-symbol into 399d65f on RubyMoney:master.

@antstorm antstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satnami this looks good to me, thank you for submitting. One question — my browser shows a dot in front of the numbers in specs, is that expected? Or is it the lack of some encoding on my side or GH's font?

@satnami

satnami commented Nov 19, 2020

Copy link
Copy Markdown
Contributor Author

@antstorm thanks for spotting that, I think it was an RTL issue.
I've fixed that and added another test case for another Arabic currency

@satnami

satnami commented Nov 19, 2020 •

Copy link
Copy Markdown
Contributor Author

Another change to make it the same as Bahraini dinar Ar Wiki

@antstorm antstorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antstorm
antstorm merged commit bc98e8c into RubyMoney:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants