Show deprecation warning in comparisions #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joshhepworth could you check contributing and make sure you've covered all your bases? |
|
@semmons99 Yup. Sorry about that. I swear I looked for the contributing section in the README and just missed it the first time. |
semmons99
added a commit
that referenced
this pull request
Oct 1, 2013
…tion Show deprecation warning in comparisions
|
just pushed 6.0.0.pre5 with your commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user is comparing a non
Moneyobject to aMoneyobject, give them a better deprecation warning.Related to issue #324.