Open
Conversation
…neural network layers.
…hensive unit tests and fixed broken source file link in the documentation
…d updated documentation with fixed source file link. Added `Parametric` interface to define parameterized layers.
…ith `NumPower` utilities
…ical stability during inference, and gradient computation logic
…ical stability during inference, and gradient computation logic
…itional tests and updated shape handling
…itional tests and updated shape handling
…interface definition for output layers.
…entation and unit tests
…d/backward passes
…ence/backward passes, unit tests, and documentation updates
…ith `NumPower` utilities
…rd/inference/backward passes, unit tests
…ference/backward passes, unit tests
…rward/inference/backward passes, unit tests
There was a problem hiding this comment.
Pull request overview
This PR refactors various neural network classes to use the NumPower library. It introduces new implementations for neural network layers, networks, snapshots, and their corresponding test files. The changes also update documentation paths to reflect the new class structure organized into subdirectories.
Changes:
- Adds new neural network layer implementations (Dense, Activation, Binary, Continuous, Multiclass, Dropout, Noise, BatchNorm, PReLU, Swish, Placeholder1D) using NumPower
- Introduces Network and FeedForward classes with comprehensive test coverage
- Updates initializers to include explicit
locparameter for NumPower compatibility - Updates documentation paths to reflect new directory structure
Reviewed changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/NeuralNet/Networks/Network.php | New base Network class implementation using NumPower |
| src/NeuralNet/FeedForwards/FeedForward.php | New FeedForward network extending Network |
| src/NeuralNet/Layers//.php | New layer implementations (Dense, Activation, Binary, etc.) |
| src/NeuralNet/Snapshots/Snapshot.php | New snapshot class for network state management |
| tests/NeuralNet//.php | Comprehensive test coverage for new implementations |
| src/NeuralNet/Initializers//.php | Updated to include explicit loc parameter |
| docs/neural-network/hidden-layers/*.md | Documentation path updates |
| phpunit.xml | Memory limit increase for tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.