Skip to content

fix(core): add max chord length and duplicate keybinding warnings#200

Merged
RtlZeroMemory merged 1 commit intomainfrom
guardrails/keybinding-limits
Feb 25, 2026
Merged

fix(core): add max chord length and duplicate keybinding warnings#200
RtlZeroMemory merged 1 commit intomainfrom
guardrails/keybinding-limits

Conversation

@RtlZeroMemory
Copy link
Owner

Summary

  • Reject key chord sequences longer than 8 keys (prevents unbounded trie memory and impossible-to-press combos)
  • Warn in dev mode when keybinding sequences are registered multiple times and silently replaced

Files changed

  • keybindings/parser.tsMAX_CHORD_LENGTH = 8 enforcement
  • keybindings/manager.ts — duplicate sequence warning in mergeBindingsReplacingSequences()

- Reject key chord sequences longer than 8 keys (prevents unbounded
  memory in trie matching and impossible-to-press combos)
- Warn in dev mode when keybinding sequences are registered multiple
  times and silently replaced

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

Warning

Rate limit exceeded

@RtlZeroMemory has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ff26087 and a6c2e55.

📒 Files selected for processing (2)
  • packages/core/src/keybindings/manager.ts
  • packages/core/src/keybindings/parser.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch guardrails/keybinding-limits

Comment @coderabbitai help to get the list of available commands and usage tips.

@RtlZeroMemory RtlZeroMemory merged commit d838294 into main Feb 25, 2026
31 checks passed
@RtlZeroMemory RtlZeroMemory deleted the guardrails/keybinding-limits branch February 25, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant