-
Notifications
You must be signed in to change notification settings - Fork 15
UI/UX improvements, code cleanup, and animation overhaul #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dacrab
wants to merge
20
commits into
RookieEnough:main
Choose a base branch
from
dacrab:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split 1200+ line App.tsx into modular components - Add custom hooks (useApps, useTheme, useDevMode, useToast, useLocalStorage) - Create centralized AppContext for state management - Add utility modules (storage, version, sanitize, fetch) - Enable TypeScript strict mode - Add ESLint 9 flat config + Prettier - Update to React 18.3, Vite 6, TypeScript 5.7 - Add proper Tailwind config with custom theme - Create proper project structure in src/
- Add AppIcon component (shared icon with fallback gradient) - Add SectionDivider component for repeated divider pattern - Add cleanGithubRepo and getArchScore utilities - Extract findMatchingRelease helper in useApps - Remove unused scrolledDown state from AboutView - Remove unused useToast hook - Simplify CategoryFilter dropdown styling - Update AppCard/AppDetail to use AppIcon
- Simplify AppContext: remove unused import, cleaner useMemo deps - Simplify all hooks: shorter var names, inline functions - Simplify all components: inline interfaces, tighter formatting - Use compareVersions in Header instead of !== check - Simplify storage utils: inline quota handling - Simplify useApps: cleaner cache logic, shorter names - Remove unnecessary wrapper divs and comments
- Add Zustand (~1KB) for state management with automatic selectors - Parallel GitHub API fetches (batches of 5) instead of sequential - Add 200ms debounce to search input - Remove AppContext, useApps, useTheme, useDevMode hooks - Persist theme, installed versions, dev mode, and settings - Components only re-render when their selected state changes
- Remove hooks folder (useLocalStorage moved to store) - Strict tsconfig: exactOptionalPropertyTypes, noImplicitReturns, verbatimModuleSyntax - Strict ESLint: strictTypeChecked, no-explicit-any, prefer-nullish-coalescing - Minimal vite.config.ts - Fix all lint errors (61 → 0)
- Fix extra whitespace in findRelease signature - Make magic numbers readable (CACHE_TTL, MB) - Use ref instead of DOM traversal for token input
- Remove unused exports (AppIcon, AppCard, SectionDivider from barrel) - Remove unused shuffleArray function - Remove redundant @typescript-eslint/* packages (use typescript-eslint) - Add @eslint/js (was unlisted) - Add knip.json config
- React 18.3.1 → 19.2.3 - Vite 6.4.1 → 7.3.0 - @vitejs/plugin-react 4.x → 5.x - All checks passing
- Sync CURRENT_STORE_VERSION with package.json (1.1.0) - Use STORAGE_KEYS constants in KEYS_TO_PRESERVE (prevent sync issues) - Remove redundant double exports in utils/index.ts
- CI: typecheck, lint, build on push/PR - Deploy: auto-deploy to GitHub Pages on main - Deps: weekly dependency updates with auto-PR - .env.example for GitHub token
- Add orchestrated entrance animations with staggered delays - Implement staggered grid card animations using CSS custom properties - Improve keyframes with spring-like cubic-bezier easing - Add scale-in and float animations - Replace light/dusk/dark with light/dusk/system theme cycle - Add system theme preference detection with real-time listener - Fix header overlap with search bar
- Simplify SearchBar with integrated refresh button - Replace category dropdown with horizontal scrollable pills - Move Dev/About tab from bottom nav to header - Streamline bottom nav to Apps/PC only - Consistent pill button styling throughout
- Extract timing constants (cache TTL, debounce, toast duration) - Extract tap count thresholds to constants - Replace dark: with dusk: prefix throughout codebase - Add SCROLL_THRESHOLD, API_BATCH_SIZE constants
Keep only meaningful constants: - DEV_TAP_TARGET, EASTER_EGG_TAP_TARGET (business logic) - API_BATCH_SIZE (reused) - NETWORK_TIMEOUT_MS (configurable) Inline obvious implementation details like debounce/toast durations
- storage.ts: Remove dead STORAGE_KEYS, simplify to specific methods - constants.ts: Remove single-use constants (API_BATCH_SIZE, tap targets) - AppIcon: Move CATEGORY_GRADIENTS here (only consumer) - AboutView: Inline SectionDivider component - Remove barrel exports (utils/index.ts, components/index.ts) - Merge version.ts into sanitize.ts - Remove unnecessary memo() from 9 components - Keep memo only on AppCard/AppGrid where it helps Deleted files: - src/utils/index.ts - src/utils/version.ts - src/components/index.ts - src/components/SectionDivider.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Major modernization of the OrionStore codebase including framework upgrades, architecture improvements, UI/UX enhancements, and comprehensive code cleanup.
📦 Framework & Dependencies
Upgraded to Latest Stack
@themesyntax🏗️ Architecture Overhaul
State Management
Code Organization
🎨 UI/UX Improvements
Redesigned Layout
Animation System
cubic-bezier(0.34, 1.56, 0.64, 1)for bouncy feelscale-in,float, improvedpulse-glowmemo()wrappers (kept only where beneficial)Theme System
dark:→dusk:Tailwind prefix throughoutModal Improvements
🧹 Code Quality
Removed Over-Engineering
STORAGE_KEYS(Zustand handles persistence)version.tsintosanitize.tsSectionDividercomponent (used once)CATEGORY_GRADIENTStoAppIcon(only consumer)Deleted Files
src/utils/index.ts- barrel exportsrc/utils/version.ts- mergedsrc/components/index.ts- barrel exportsrc/components/SectionDivider.tsx- inlinedAdded
.env.examplefor configuration✅ Quality Checks
📊 Impact