Skip to content

fix: DecomposeGenericByUnfoldingPermutation pass #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

fix: DecomposeGenericByUnfoldingPermutation pass #19

merged 1 commit into from
Jun 2, 2025

Conversation

chrsmcgrr
Copy link
Collaborator

@chrsmcgrr chrsmcgrr commented May 26, 2025 •
edited
Loading

The following PR is attempting to:

  1. extend the decompose pass to also reason about scalars which can appear on generic functions
  2. Reject any operands that are not RankedTensors. As this pass was created with this assumption. Though this pass can be naturally called on linalg with memref or any type.

[x] add another test to make sure linalg on memref does not segfault

@chrsmcgrr Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chrsmcgrr chrsmcgrr force-pushed the chris/roo-413-linalg-allow-scalars-in branch from 1587212 to 9aeeddc Compare May 27, 2025 12:54
@chrsmcgrr chrsmcgrr marked this pull request as ready for review May 28, 2025 09:37
@chrsmcgrr chrsmcgrr requested a review from a team May 28, 2025 09:37
maxbartel
maxbartel approved these changes May 28, 2025
View reviewed changes
@chrsmcgrr chrsmcgrr force-pushed the chris/roo-413-linalg-allow-scalars-in branch 2 times, most recently from 4e9fbff to 4448c6d Compare June 2, 2025 15:31
@chrsmcgrr chrsmcgrr force-pushed the chris/roo-413-linalg-allow-scalars-in branch from 4448c6d to 635d2c3 Compare June 2, 2025 15:52
@chrsmcgrr chrsmcgrr merged commit c357983 into integrate-llvm-project-20250508 Jun 2, 2025
6 checks passed
@chrsmcgrr chrsmcgrr deleted the chris/roo-413-linalg-allow-scalars-in branch July 9, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbartel maxbartel maxbartel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrsmcgrr @maxbartel