fix(linag.pack): decompisition of OuterUnitDims Pattern #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
chrsmcgrr
force-pushed
the
chris/roo-395-fix-pack-decomposition
branch
2 times, most recently
from
85d6f7a to
2fce8ff
Compare
|
|
AGindinson
approved these changes
May 23, 2025
maxbartel
approved these changes
May 23, 2025
chrsmcgrr
force-pushed
the
chris/roo-395-fix-pack-decomposition
branch
2 times, most recently
from
7355aa1 to
4033b94
Compare
given the following example:
```
module {
func.func @main(%arg0: tensor<1x1x1x4x1xf32>, %arg1: tensor<1x1x4xf32>) -> tensor<1x1x1x4x1xf32> {
%pack = linalg.pack %arg1 outer_dims_perm = [1, 2, 0] inner_dims_pos = [2, 0] inner_tiles = [4, 1] into %arg0 : tensor<1x1x4xf32> -> tensor<1x1x1x4x1xf32>
return %pack : tensor<1x1x1x4x1xf32>
}
}
```
we would generate an invalid transpose operation because the calculated
permutation would be `[0, 2, 0]` which is semantically incorrect. As the
permutation must contain unique integers corresponding to the source
tensor.
The following change attempts to amend that.
chrsmcgrr
force-pushed
the
chris/roo-395-fix-pack-decomposition
branch
from
4033b94 to
2c1f0aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following example:
We would generate an invalid transpose operation because the calculated permutation would be
[0, 2, 0]which is semantically incorrect. As the permutation must contain unique integers corresponding to the source tensor.The assumption that because all outer dimensions are 1 the transposition does not matter does not hold because the indices in
permutationmust be unique and match the source tensor indices.The following change attempts to amend that.