Skip to content

[DNM] Introduce lexical to improve textarea (better context mention UX, no more hacks with regex, etc) #2881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elianiva
Copy link

@elianiva elianiva commented Apr 23, 2025

it's still in a very rough condition, but basic text editing works for now
just putting this up to let people know and avoid duplicate effort

todo:

  • basic text editing
  • properly handle keyboard events
  • handle commands (currently only used to change mode, but we can expand the idea further)
  • handle copy/paste for files
  • handle drag and drop
  • handle mention (file, commits, etc)
  • display mention in a better format
  • show included context in current prompt
  • other edge cases i haven't found yet
  • add tests, there's currently none

a lot of these are generated by gemini 2.5 pro as you can tell by a lot of these useless comments, i've adjusted a few of them but there are still a lot of stuff that needs to be fixed ((it was struggling with apply_diff a lot once it reaches a certain point i ended up stopping it and just do it by hand))

i'll be adjusting/fixing them along the way and posting updates here (and discord)

feel free to comments any of your ideas :)

Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: ff20b25

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cte
Copy link
Collaborator

cte commented Apr 23, 2025

Nice! I noticed that they have a mentions plugin; should we use that or roll our own?

@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap Apr 23, 2025
@elianiva
Copy link
Author

Nice! I noticed that they have a mentions plugin; should we use that or roll our own?

currently i want to try to roll our own because i want to experiment a bit with it, having more control is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR [Pre Approval Review]
Development

Successfully merging this pull request may close these issues.

2 participants