Merged
Conversation
dosubot
bot
added
size:XS
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
| className="w-full"> | ||
| {IMAGE_GENERATION_MODELS.map((model) => ( | ||
| <VSCodeOption key={model.value} value={model.value}> | ||
| <VSCodeOption key={model.value} value={model.value} className="py-2 px-3"> |
Contributor
There was a problem hiding this comment.
I noticed you're using className="py-2 px-3" for padding here. For consistency with other VSCodeOption components in the codebase, could we consider using className="p-2" instead?
Other files like webview-ui/src/components/settings/providers/Moonshot.tsx, webview-ui/src/components/settings/providers/ZAi.tsx, and webview-ui/src/components/chat/CodeIndexPopover.tsx all use p-2 for their VSCodeOption elements.
Is there a specific reason for the different padding values (py-2 px-3 vs p-2), or would aligning with the existing pattern work for this use case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds padding to
VSCodeOptionelements inImageGenerationSettings.tsxfor better spacing in the dropdown.py-2 px-3padding toVSCodeOptionelements inImageGenerationSettings.tsxto improve spacing in the image model picker dropdown.This description was created by
for faf5410. You can customize this summary. It will automatically update as commits are pushed.