You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hmm I'm not sure it was introduced here - I think the code is the same as it used to be. Can you send a screenshot of your error? I think it's actually related to the async checkpoints showing up in the middle of another call (and I was planning on trying to fix that today).
After this patch, read function works properly on local setup. Made this change based on the error message I saw. If actually this is a race condition, the real fix might need to be somewhere else - this patch might just help by making the read return a bit slower.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes intermittent "Current ask promise was ignored" during file read with new read tool introduced in #2059
Important
Adds error handling for
cline.askinreadFileToolto prevent ignored promise errors during file reads.cline.askinreadFileToolto prevent 'Current ask promise was ignored' errors.cline.askfails, logs error usingpushToolResultwith a formatted tool error message.readFileTool.tsto include atry-catchblock aroundcline.ask.This description was created by
for 2e227e9. It will automatically update as commits are pushed.