fix(windows): correct UNC/WSL path decoding + bump to 1.1.2#28
Open
marceloterra1983 wants to merge 1 commit intoRonitSachdev:mainfrom
Open
fix(windows): correct UNC/WSL path decoding + bump to 1.1.2#28marceloterra1983 wants to merge 1 commit intoRonitSachdev:mainfrom
marceloterra1983 wants to merge 1 commit intoRonitSachdev:mainfrom
Conversation
The previous cross-platform fix (PR RonitSachdev#6) treated all `--` sequences as drive letter separators (`C:\`), which broke UNC/WSL paths like `--wsl-localhost-Ubuntu-...` (decoded as `:\wsl\...` instead of `//wsl/...`). Now `--` is only decoded as a drive letter when preceded by `[A-Z]`. Otherwise it's treated as a UNC prefix (`//`). Also bumps version to 1.1.2 since PR RonitSachdev#6 fixes were merged to main but never published to npm. Fixes RonitSachdev#27 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAllSessions()incorrectly decoding UNC/WSL paths on Windows (e.g.--wsl-localhost-...was decoded as:\wsl\...instead of//wsl/...)Problem
The cross-platform fix from PR #6 treated all
--sequences as drive letter separators (C:\), which broke UNC/WSL paths:Fix
Now
--is only decoded as a drive letter when preceded by[A-Z](e.g.C--Users). Otherwise it falls through to the Unix/UNC branch which correctly handles//prefixes.Additional note
PR #6 (
os.homedir(), Windows path encoding) was merged tomainbut v1.1.1 on npm still has the oldprocess.env.HOMEcode. This PR bumps to 1.1.2 so those fixes can be published too.Closes #27
Test plan
ccundo liston Windows 11 fromC:\Users\marce— lists operations correctlyccundo sessions— Windows paths show asC:\Users\marce, WSL paths show as//wsl/localhost/...getCurrentProjectDir()— encodesC:\Users\marceasC--Users-marcematching Claude Code's format🤖 Generated with Claude Code