Refactoring #16
Merged
Refactoring #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryusenko
force-pushed
the
refactoring
branch
from
a5fbe6c to
c3fd638
Compare
refactor: use array destructuring refactor: remove redundant variable inside binarize method, and move it to a separate file refactor: use generic types instead of type assertion fix: update error message refactor: make inputFeatureExtractors and outputFeatureExtractor parameters optional refactor: improve BinaryClassificationTrainer constructor refactor: remove optional parameters from example application refactor: add return type refactor: rename printResults to printTestingResults refactor: use for-of instead of forEach
astorozhevsky
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
batchSize,epochsandpatienceparameters.inputFeatureExtractorsandoutputFeatureExtractorparameters optional.printResultstoprintTestingResults.