#87: Ability to work with Rule facade #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sIT/laravel-swagger into 87_ability_to_work_with_rule_facade
DenTray
requested changes
Jun 13, 2023
src/Services/SwaggerService.php
Outdated
Comment on lines
375
to
387
| if (is_string($rule)) { | ||
| return $rule; | ||
| } | ||
|
|
||
| $reflectionRule = new ReflectionClass($rule); | ||
|
|
||
| if ($reflectionRule->hasMethod('__toString')) { | ||
| return $rule->__toString(); | ||
| } | ||
|
|
||
| $ruleName = preg_replace('/Rule$/', '', $reflectionRule->getShortName()); | ||
|
|
||
| return $this->toSnakeCase($ruleName); |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (is_string($rule)) { | |
| return $rule; | |
| } | |
| $reflectionRule = new ReflectionClass($rule); | |
| if ($reflectionRule->hasMethod('__toString')) { | |
| return $rule->__toString(); | |
| } | |
| $ruleName = preg_replace('/Rule$/', '', $reflectionRule->getShortName()); | |
| return $this->toSnakeCase($ruleName); | |
| if (is_object($rule)) { | |
| if (method_exists($rule, '__toString')) { | |
| return $rule->__toString(); | |
| } | |
| $shortName = extract_last_part(get_class($class), '\\') | |
| $ruleName = preg_replace('/Rule$/', '', $shortName); | |
| return $this->toSnakeCase($ruleName); | |
| } | |
| return $rule; |
src/Services/SwaggerService.php
Outdated
|
|
||
| public static function toSnakeCase(string $string): string | ||
| { | ||
| return strtolower(preg_replace('/(?<!^)[A-Z]/', '_$0', $string)); |
Collaborator
There was a problem hiding this comment.
Suggested change
| return strtolower(preg_replace('/(?<!^)[A-Z]/', '_$0', $string)); | |
| return (function_exists('snake_case')) ? snake_case($string) : Str::snake($string); |
…sIT/laravel-swagger into 87_ability_to_work_with_rule_facade
…sIT/laravel-swagger into 87_ability_to_work_with_rule_facade
DenTray
requested changes
Jun 14, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
DenTray
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: