Skip to content

#67: Increase coverage by unit tests #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 1, 2023
Merged

#67: Increase coverage by unit tests #75

merged 10 commits into from
Mar 1, 2023

Conversation

@vitgrams
Copy link
Contributor

@vitgrams vitgrams commented Feb 27, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vitgrams vitgrams force-pushed the 67_increase_covering_by_unit_tests branch from 6b0d189 to db8cdba Compare February 27, 2023 12:46
@vitgrams vitgrams requested a review from DenTray February 27, 2023 12:49
@vitgrams
Copy link
Contributor Author

vitgrams commented Feb 27, 2023

@DenTray Done. Could you please review this code?

@vitgrams vitgrams changed the title #67: Increase covering by unit tests #67: Increase coverage by unit tests Feb 27, 2023
DenTray
DenTray requested changes Feb 27, 2023
View reviewed changes
@vitgrams
Copy link
Contributor Author

vitgrams commented Feb 28, 2023

@DenTray All conversations have benn resolved. Could you please take another look at this?

@vitgrams vitgrams assigned DenTray and unassigned DenTray Feb 28, 2023
DenTray
DenTray requested changes Feb 28, 2023
View reviewed changes
@vitgrams vitgrams assigned DenTray and unassigned DenTray Feb 28, 2023
DenTray
DenTray requested changes Mar 1, 2023
View reviewed changes
DenTray
DenTray requested changes Mar 1, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenTray DenTray merged commit 7187aa0 into master Mar 1, 2023
@DenTray DenTray deleted the 67_increase_covering_by_unit_tests branch September 18, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenTray DenTray DenTray approved these changes

Assignees

@DenTray DenTray

Labels

state: code review type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitgrams @DenTray