163 modify 500 code error response page #174

RGO230 · 2025-07-02T12:38:03Z

#163

…hub.com/RonasIT/laravel-swagger into 163-modify-500-code-error-response-page

sonarqubecloud · 2025-07-09T15:03:59Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

src/Services/SwaggerService.php

Copilot

Pull Request Overview

This PR modifies the error response page formatting for Swagger validation errors, addressing issue #163. The changes enhance error presentation with structured markdown formatting and proper error context display.

Reformats error page display with markdown structure including headers and visual separators
Updates error handling to include exception type information alongside error messages
Fixes test parameter ordering and adds new test case for incorrect documentation structure

Reviewed Changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
resources/views/error.blade.php	Updates error page template with structured markdown formatting
src/Services/SwaggerService.php	Modifies exception handling to capture and pass exception type information
tests/SwaggerServiceTest.php	Updates test expectations and adds new test case for documentation structure errors
tests/TestCase.php	Fixes parameter order in exportContent method call
tests/fixtures/SwaggerServiceTest/*.html	Updates all error fixture files to match new markdown-formatted error template

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/SwaggerServiceTest.php

src/Services/SwaggerService.php

tests/SwaggerServiceTest.php

Copilot

Pull Request Overview

Copilot reviewed 62 out of 64 changed files in this pull request and generated 8 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/SwaggerServiceTest.php

tests/TestCase.php

tests/SwaggerServiceTest.php

tests/LocalDriverTest.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

DenTray · 2025-11-06T08:10:47Z

@RGO230 please review copilot's comments and increase test coverage

…hub.com/RonasIT/laravel-swagger into 163-modify-500-code-error-response-page

sonarqubecloud · 2025-11-06T11:34:08Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot

Pull Request Overview

Copilot reviewed 62 out of 64 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/SwaggerServiceTest.php

tests/LocalDriverTest.php

src/Services/SwaggerService.php

Copilot

Pull Request Overview

Copilot reviewed 62 out of 64 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/LocalDriverTest.php

Copilot · 2025-11-11T04:53:47Z

tests/StorageDriverTest.php

+
+    public function testGetInvalidJsonDocumentation(): void
+    {
+        $this->disk->put(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));


Using getFixturePath() incorrectly - this returns a file path string, not file content. Should use $this->getFixture('invalid_prod_json_data.json') to write the actual fixture content to the storage disk.

Suggested change

$this->disk->put(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));

$this->disk->put(self::$productionFilePath, $this->getFixture('invalid_prod_json_data.json'));

Copilot · 2025-11-11T04:53:47Z

tests/support/Traits/SwaggerServiceTestingTrait.php

+
+    protected function assertExceptionHTMLEqualsFixture(string $fixture, string $content, bool $exportMode = false): void
+    {
+        $content = Str::replaceMatches('/line=\d+,/', 'line=999, ', $content);


The regex pattern /line=\d+,/ matches 'line=123,' but the replacement is 'line=999, ' (with an extra space after the comma). This creates inconsistent spacing. The replacement should be 'line=999,' to maintain consistent formatting.

DenTray · 2025-11-11T05:13:15Z

tests/SwaggerServiceTest.php

+        $prodDocPath = "tests/fixtures/SwaggerServiceTest/{$prodDoc}.json";
+
+        file_put_contents($productionFilePath, file_get_contents($prodDocPath));


will it works the same?

Suggested change

$prodDocPath = "tests/fixtures/SwaggerServiceTest/{$prodDoc}.json";

file_put_contents($productionFilePath, file_get_contents($prodDocPath));

$documentation = $this->getJsonFixture($prodDoc);

file_put_contents($productionFilePath, $documentation);

DenTray · 2025-11-11T05:20:38Z

src/Services/SwaggerService.php


        $fileContent = json_decode(file_get_contents($filePath), true);

-        if (empty($fileContent)) {


why are you remove it? The additional documentation may not be exists by the path set in the config and it good to throw an error in this case

DenTray · 2025-11-11T05:28:11Z

tests/LocalDriverTest.php

+
+    public function testGetInvalidJsonDocumentation(): void
+    {
+        file_put_contents(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));


Suggested change

file_put_contents(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));

file_put_contents(self::$productionFilePath, $this->getFixture('invalid_prod_json_data'));

RGO230 added 2 commits July 2, 2025 15:35

refactor: display throwable errors too

dee3246

Merge branch '163-modify-500-code-error-response-page' of https://git…

115f599

…hub.com/RonasIT/laravel-swagger into 163-modify-500-code-error-response-page

RGO230 self-assigned this Jul 2, 2025

refactor: set empty array for not exception errors

1c7dfcf

RGO230 assigned AZabolotnikov and RGO230 and unassigned RGO230 and AZabolotnikov Jul 3, 2025

refactor: add empty email exception message to view

fe96b4b

RGO230 assigned AZabolotnikov and unassigned RGO230 Jul 9, 2025

fix: remove useless

241a8f7

AZabolotnikov reviewed Jul 31, 2025

View reviewed changes

src/Services/SwaggerService.php Outdated Show resolved Hide resolved

AZabolotnikov assigned DenTray and RGO230 and unassigned AZabolotnikov Jul 31, 2025

DenTray requested changes Aug 12, 2025

View reviewed changes

src/Services/SwaggerService.php Outdated Show resolved Hide resolved

DenTray removed their assignment Aug 12, 2025

astorozhevsky requested a review from Copilot August 28, 2025 09:37

Copilot AI reviewed Aug 28, 2025

View reviewed changes

tests/SwaggerServiceTest.php Outdated Show resolved Hide resolved

src/Services/SwaggerService.php Outdated Show resolved Hide resolved

refactor: add defaul unhandled error message

6624b40

RGO230 assigned AZabolotnikov and unassigned RGO230 Sep 1, 2025

AZabolotnikov assigned RGO230 and unassigned AZabolotnikov Sep 4, 2025

AZabolotnikov reviewed Sep 4, 2025

View reviewed changes

tests/SwaggerServiceTest.php Outdated Show resolved Hide resolved

RGO230 added 3 commits September 11, 2025 17:10

refactor: use try catch

79d523c

refactor: use try catch in correct place

66d348a

fix: tests

c48e7f2

DenTray added 3 commits November 6, 2025 13:27

Update tests/SwaggerServiceTest.php

4f0254c

Update tests/SwaggerServiceTest.php

a0ba34f

Update tests/SwaggerServiceTest.php

208ce11

DenTray requested a review from Copilot November 6, 2025 07:30

Copilot AI reviewed Nov 6, 2025

View reviewed changes

Update tests/SwaggerServiceTest.php

5c8cfeb

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

DenTray assigned RGO230 and unassigned AZabolotnikov Nov 6, 2025

RGO230 added 4 commits November 6, 2025 13:56

tests: make correct php 8.4 tests

c07712a

Merge branch '163-modify-500-code-error-response-page' of https://git…

b6ab02c

…hub.com/RonasIT/laravel-swagger into 163-modify-500-code-error-response-page

fix:tests

30f0f23

refactor: remove useless

8a1c80b

RGO230 assigned AZabolotnikov and unassigned RGO230 Nov 6, 2025

AZabolotnikov assigned DenTray and unassigned AZabolotnikov Nov 7, 2025

DenTray requested a review from Copilot November 11, 2025 03:34

Copilot started reviewing on behalf of DenTray November 11, 2025 03:35 View session

Copilot finished reviewing on behalf of DenTray November 11, 2025 03:36

Copilot AI reviewed Nov 11, 2025

View reviewed changes

tests/SwaggerServiceTest.php Show resolved Hide resolved

tests/LocalDriverTest.php Show resolved Hide resolved

src/Services/SwaggerService.php Show resolved Hide resolved

DenTray requested a review from Copilot November 11, 2025 04:50

Copilot started reviewing on behalf of DenTray November 11, 2025 04:51 View session

Copilot finished reviewing on behalf of DenTray November 11, 2025 04:53

Copilot AI reviewed Nov 11, 2025

View reviewed changes

DenTray requested changes Nov 11, 2025

View reviewed changes

DenTray assigned RGO230 and unassigned DenTray Nov 11, 2025

	$this->disk->put(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));
	$this->disk->put(self::$productionFilePath, $this->getFixture('invalid_prod_json_data.json'));

		$prodDocPath = "tests/fixtures/SwaggerServiceTest/{$prodDoc}.json";

		file_put_contents($productionFilePath, file_get_contents($prodDocPath));


		$fileContent = json_decode(file_get_contents($filePath), true);

		if (empty($fileContent)) {

	file_put_contents(self::$productionFilePath, $this->getFixturePath('invalid_prod_json_data'));
	file_put_contents(self::$productionFilePath, $this->getFixture('invalid_prod_json_data'));

163 modify 500 code error response page #174

Are you sure you want to change the base?

163 modify 500 code error response page #174

Conversation

RGO230 commented Jul 2, 2025

Uh oh!

sonarqubecloud bot commented Jul 9, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DenTray commented Nov 6, 2025

Uh oh!

sonarqubecloud bot commented Nov 6, 2025

Quality Gate passed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

DenTray Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

DenTray Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

DenTray Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants