Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Review #431

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Log Review #431

merged 5 commits into from
Oct 17, 2023

Conversation

Romanitho
Copy link
Owner

Proposed Changes

  • Review log management
  • Added log on WAU installation

@Romanitho Romanitho temporarily deployed to megalinter October 17, 2023 20:37 — with GitHub Actions Inactive
@Romanitho
Copy link
Owner Author

@KnifMelti is that ok with your work? 😇

@github-actions
Copy link
Contributor

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 9 2.4s
✅ POWERSHELL powershell 6 0 17.2s
✅ POWERSHELL powershell_formatter 6 0 10.68s
⚠️ REPOSITORY checkov yes 1 10.77s
⚠️ REPOSITORY devskim yes 4 2.78s
✅ REPOSITORY dustilock yes no 0.02s
✅ REPOSITORY gitleaks yes no 0.61s
⚠️ REPOSITORY git_diff yes 1 0.01s
✅ REPOSITORY grype yes no 12.57s
✅ REPOSITORY kics yes no 14.08s
✅ REPOSITORY secretlint yes no 1.28s
✅ REPOSITORY syft yes no 0.27s
✅ REPOSITORY trivy yes no 3.77s
✅ REPOSITORY trivy-sbom yes no 1.29s
⚠️ REPOSITORY trufflehog yes 1 3.95s
⚠️ SPELL cspell 7 73 9.18s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@KnifMelti
Copy link
Contributor

You said tomorrow 😍

@Romanitho
Copy link
Owner Author

yes, but I want it in the nightly built of tonight ^^

@Romanitho
Copy link
Owner Author

seams OK so far on my side. I merge, will see tomorrow for troubleshoot in case something is broken

@Romanitho Romanitho merged commit 778a751 into main Oct 17, 2023
@Romanitho Romanitho deleted the dev branch October 17, 2023 20:47
@Romanitho
Copy link
Owner Author

Romanitho commented Oct 17, 2023

if everything is good, I'll work on ServiceUI. I have a plan to onboard it with Github Actions. This way, it comes from the MDT .msi and it only picks serviceUI.exe that is very light.
Inside the .github/workflows/CreateNewRelease.yml I will add something like this:
`

      - name: Build project
        run: |
          # Get MDT from Microsoft
          wget https://download.microsoft.com/download/3/3/9/339BE62D-B4B8-4956-B58D-73C4685FC492/MicrosoftDeploymentToolkit_x64.msi
          # Extract MSI
          7z x MicrosoftDeploymentToolkit_x64.msi
          # Copy ServiceUI.exe to Winget-AutoUpdate folder
          mv Modena_File206 Winget-AutoUpdate/ServiceUI.exe
          # Zip WAU
          zip -r WAU.zip Winget-AutoUpdate
          zip WAU.zip Winget-AutoUpdate-Install.ps1
          zip WAU.zip excluded_apps.txt
          zip WAU.zip install.bat
          zip WAU.zip uninstall.bat
          # Zip ADMX
          cd Policies
          zip -r ../WAU_ADMX.zip *
          cd ..

@KnifMelti
Copy link
Contributor

KnifMelti commented Oct 17, 2023

I have a plan to onboard it with Github Actions

What an intricate world we live in nowadays... 🤪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants