Repository navigation
Names should not be stored in a TValuedSyntaxNode #222
Description
The TValuedSyntaxNode has no benefit over a normal ntName node that stores the name in the [anName] attribute.
I suggest the following changes:
procedure TPasSyntaxTreeBuilder.AttributeArgumentName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntName).SetAttribute(anName,Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.AttributeName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntname).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.ConstantName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntName).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.ExceptionVariable;
begin
FStack.Push(ntVariable);
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntName).SetAttribute(anName, Lexer.Token);
try
inherited;
finally
FStack.Pop;
end;
end;
procedure TPasSyntaxTreeBuilder.FieldName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntname).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.FunctionMethodName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntName).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.ObjectNameOfMethod;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntName).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.ParameterName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntname).SetAttribute(anName, Lexer.Token);
inherited;
end;
procedure TPasSyntaxTreeBuilder.VarName;
begin
//FStack.AddValuedChild(ntName, Lexer.Token);
FStack.AddChild(ntname).SetAttribute(anName, Lexer.Token);
inherited;
end;This simplifies the code and avoids the duplication between the anName attribute and the FValue member. Why have the anName attribute if not to store the name?
Activity
RomanYankovsky#222, use the anName attribute to store names exclusively