Feature/shops #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MendicantBias90
commented
Oct 29, 2017
MendicantBias90
commented
- Add a Shop TabNavigator
- Add shop screens
- Customizable ShopRow component
- Init CategoryPicker component
- Load assets
- Add colour constants
Takeno
requested changes
Oct 30, 2017
src/MainNavigation.js
Outdated
| import OnlineShops from './screen/OnlineShops'; | ||
| import SearchShop from './screen/SearchShop'; | ||
|
|
||
| const Shops = TabNavigator( |
There was a problem hiding this comment.
Please, move TabNavigator to ./screen/Shops as we made for Coupons
src/component/CategoryPicker.js
Outdated
| renderChoices() { | ||
| return ( | ||
| <View style={styles.choiceContainer}> | ||
| <TouchableOpacity |
There was a problem hiding this comment.
Consider to use a single array for categories and iterate on it to create choices
src/component/ShopRow.js
Outdated
| {this.props.shop.distance && ( | ||
| <Text style={styles.distance}> | ||
| {this.props.shop.distance >= 1000 | ||
| ? `${this.props.shop.distance / 1000}km` |
There was a problem hiding this comment.
Consider to use number.toFixed(2) to limit the decimal digits
src/screen/NearShops.js
Outdated
| return ( | ||
| <View style={styles.container}> | ||
| <FlatList | ||
| data={[ |
There was a problem hiding this comment.
Please, use an external array with fixtures data. It will be easier to replace it with dynamic data
Takeno
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.