Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support strict with_role queries. Issue #362 #543

Merged
merged 6 commits into from
Jun 28, 2020
Merged

Support strict with_role queries. Issue #362 #543

merged 6 commits into from
Jun 28, 2020

Commits on May 29, 2020

  1. Support strict with_role queries 

    Why:

* There is an outstanding issues #362
* strict mode should be enforced on role queries and resource queries

How:

* Pass a strict flag to the scope function
* call where or where_strict depending on strict flag in active_record adapter
* Add tests for strict mode resource queries

Note:

* This PR does not address strict mode for mongoid since I am unfamiliar with that ORM
    @Mrjaco12
    Mrjaco12 committed May 29, 2020
    Configuration menu
    Copy the full SHA
    c4e169f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2020

  1. Update where_strict for mongoid 

    Why:

* The tests will fail until mongo works with strict resource querying

This change addresses the need by:

* Copy the where_strict implementation from the active record adapter
    @Mrjaco12
    Mrjaco12 committed May 30, 2020
    Configuration menu
    Copy the full SHA
    3d75c65 View commit details
    Browse the repository at this point in the history

  2. Make sure to call strict where

    @Mrjaco12
    Mrjaco12 committed May 30, 2020
    Configuration menu
    Copy the full SHA
    71dcbec View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2020

  1. Merge branch 'master' into master

    @thomas-mcdonald
    thomas-mcdonald authored Jun 10, 2020
    Configuration menu
    Copy the full SHA
    567b694 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Refactor to reduce mutations

    @Mrjaco12
    Mrjaco12 committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    1988e8e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:Mrjaco12/rolify

    @Mrjaco12
    Mrjaco12 committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    22d1ab3 View commit details
    Browse the repository at this point in the history