Faster way to add roles

[v-kumar]

This method is much faster than role_ids |= [role.id].

.include? does a fast exists check without having to load all the ids. The slowness is not in the insert, but in loading all the role_ids, which is not needed here.

[EppO]

LGTM

[EppO]

Hi @v-kumar,

the test suite is not kicking off on Travis-ci that raises a "Abuse detected" error. I got in touch with Travis-ci support that told me the organization you used (Ogwee) to create the fork never logged in Travis-ci and may have trigger this false positive in their abuse detection process.
Here is the communication I had with them:

Thanks for writing in and sorry for the troubles.

I've been looking into these rejected requests and I see that the Ogwee organization nor any of its members have been never logged into Travis CI and this is why we are currently blocking these requests that come from Ogwee's' fork of the RolifyCommunity/rolify repository. Sorry for the inconvenience.

We are looking into fixing this false positive in our abuse detection system, as we don't feel that an organization or account should have to create a Travis account when working with another project that is using Travis CI.

To sort this out in the meantime, do you know who manages this organization and do you think one of their members could try to log into Travis CI at least once at https://travis-ci.org/ and try closing and reopen one of the rejected Pull Requests?

Please let us know the result and we would be happy to have another look if it's still not working.

Thanks in advance and have a great day!

Best,
Carla

Can you try to login with your github account on Travis to unblock the PR? Or if you can't/don't want to, you can re-create a fork using your personal account, not the Ogwee organization, that maybe would do the trick.

Thanks

[v-kumar]

Hi @EppO

Sorry, it took a while for me to see your earlier message.

I just granted the access to travis-ci.

You should be all set now.

Let me know once this gets merged,

[coveralls]

Coverage remained the same at 93.089% when pulling 93d590b on Ogwee:master into 154748c on RolifyCommunity:master.

[coveralls]

Coverage remained the same at 93.089% when pulling 93d590b on Ogwee:master into 154748c on RolifyCommunity:master.

[coveralls]

Coverage remained the same at 93.089% when pulling 93d590b on Ogwee:master into 154748c on RolifyCommunity:master.

[coveralls]

Coverage remained the same at 93.089% when pulling 93d590b on Ogwee:master into 154748c on RolifyCommunity:master.

[thomas-mcdonald]

I'm investigating similar performance issues with one of our applications, it would be great to get this merged in. Is there anything I can do to help this land?

[v-kumar]

The CI failed because it ran out of time. Can we please get this merged?

@EppO

[EppO]

Merge done. Thanks for you PR. really appreciated

[dprater]

Looks like this PR has been merged into the master branch, but it's not in the latest gem release (5.2.0), and it's not even tagged. The only way for us to get this fix (which is very important for us - we're seeing 60+ seconds for role creations in some cases) is to point our Gemfile at this specific commit, which we'd prefer not to do if possible. We'd like to at least be able to point at a specific release (although ideally you'd just create a tag and then push that tag to rubygems to make the fix available to everyone). Any way a new gem release could be done, or at least a new tagged release in GitHub we could point to?