Merged
Conversation
zoopmaster
approved these changes
Mar 11, 2025
scriswell
approved these changes
Mar 11, 2025
Collaborator
scriswell
left a comment
There was a problem hiding this comment.
@Jeremy-Walton This seems to have added quite a few package dependancies, along with some new postCSS elements. I don't have the familiarity for most of these to give a complete review so I thought I would just ask the question.
Member
Author
|
@scriswell Correct it does, but they are development dependencies that are just used in the final build step for distribution. They are not included in the outputted package and not used by anyone consuming the package. The main goal of them was to update the build step to actually minify the code for distribution. That screenshot above is what the actual code output for people using the package looks like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Even though the
distfolder includes anoptics.min.css, it wasn't actually minified. It was just a combined output.What Changed
dist/optics.cssto be a combined file since it doesn't need to be multiple.dist/optics.min.cssto actually be minified.distfolder only includes necessary files. In this case, LICENSE, README.md, and package.jsonSanity Check
[ ] Have you updated any usage of changed tokens?[ ] Have you updated the docs with any component changes?[ ] Have you updated the dependency graph with any component changes?v2.1.1)Screenshots