Merged
Conversation
… addon for using the full variable library Also include documentation explaining usage
dominicmacaulay
approved these changes
Feb 11, 2025
…nd specific icon pack
scriswell
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In order to improve the out of the box Optics experience as well as the ease of customizing icons, changes to how the component was built were needed. Additionally some performance improvements were made to reduce initial page load time
What Changed
.icon--smallmodifier.iconas a necessary class to be used in conjunction with.material-symbols-outlined. This make a clear separation from what is generally needed for an icon and what is specific for material symbols. This also sets the stage for future icon pack support.Sanity Check
Screenshots
Old Icon loading
New Icon loading