Skip to content

[OP-200] Move fonts to their own files#271

Merged
Jeremy-Walton merged 4 commits intomainfrom
op-200-move-font-imports-to-their-own-folder
Feb 11, 2025
Merged

[OP-200] Move fonts to their own files#271
Jeremy-Walton merged 4 commits intomainfrom
op-200-move-font-imports-to-their-own-folder

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Feb 11, 2025

Why?

Moving the font imports to their own files allows for better organizing, overriding, customizing, and clearer documentation.

What Changed

  • Move font imports out of icon and base tokens and into core/fonts/text_fonts.css and core/fonts/icon_fonts.css
  • Update selective imports documentation
  • Update file organization documentation
  • Update comments in documentation code examples to use the correct syntax
  • Update dependency notes and the graph to include the fonts

Sanity Check

  • [ ] Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Have you updated the dependency graph with any component changes?
  • Have you run linters?
  • Have you run prettier?
  • Have you tried building the css?
  • Have you tried building storybook?
  • [ ] Do you need to update the package version?

Screenshots

Screenshot 2025-02-10 at 9 55 16 PM Screenshot 2025-02-10 at 9 55 27 PM Screenshot 2025-02-10 at 9 55 31 PM Screenshot 2025-02-10 at 9 56 08 PM Screenshot 2025-02-10 at 11 06 13 PM Screenshot 2025-02-10 at 11 06 25 PM

@Jeremy-Walton Jeremy-Walton added documentation Improvements or additions to documentation Cleanup Clean up styles Breaking Change This will cause problems so be sure to indicate that in the release notes Base Tokens Changes to the base tokens labels Feb 11, 2025
@Jeremy-Walton Jeremy-Walton self-assigned this Feb 11, 2025
@linear
Copy link

linear bot commented Feb 11, 2025

@Jeremy-Walton Jeremy-Walton merged commit 8445f9e into main Feb 11, 2025
1 check passed
@Jeremy-Walton Jeremy-Walton deleted the op-200-move-font-imports-to-their-own-folder branch February 11, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Base Tokens Changes to the base tokens Breaking Change This will cause problems so be sure to indicate that in the release notes Cleanup Clean up styles documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

2 participants