Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhanced validation #54

Merged
merged 4 commits into from
Aug 26, 2020
Merged

enhanced validation #54

merged 4 commits into from
Aug 26, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added 🔥 enhancement New feature or request :shipit: merge Shipit! labels Aug 26, 2020
@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #54 into master will decrease coverage by 4.75%.
The diff coverage is 56.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   67.18%   62.43%   -4.76%     
==========================================
  Files         157      171      +14     
  Lines        3255     3538     +283     
  Branches      293      301       +8     
==========================================
+ Hits         2187     2209      +22     
- Misses       1068     1329     +261     
Impacted Files Coverage Δ
...ensions/Validation/CompositeValidatorDescriptor.cs 0.00% <0.00%> (ø)
src/Grpc/NotFoundInterceptor.cs 0.00% <0.00%> (ø)
...ample/Sample.Grpc/Services/LaunchRecordsService.cs 14.92% <14.92%> (ø)
src/Grpc/Validation/ValidationInterceptor.cs 31.03% <31.03%> (ø)
sample/Sample.Grpc/Services/RocketsService.cs 42.85% <42.85%> (ø)
src/Extensions/Validation/CompositeValidator.cs 93.75% <93.75%> (ø)
....Core/Operations/LaunchRecords/EditLaunchRecord.cs 94.87% <100.00%> (+0.13%) ⬆️
...ample/Sample.Core/Operations/Rockets/EditRocket.cs 95.12% <100.00%> (+0.12%) ⬆️
sample/Sample.Grpc/Startup.cs 100.00% <100.00%> (ø)
sample/Sample.Grpc/WellKnownGrpcTypesProfile.cs 100.00% <100.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5b5ba0...02c3e5e. Read the comment docs.

@github-actions github-actions bot modified the milestone: v0.1.0 Aug 26, 2020
@david-driscoll david-driscoll merged commit a029dd0 into master Aug 26, 2020
@mergify mergify bot removed the :shipit: merge Shipit! label Aug 26, 2020
@mergify mergify bot deleted the feature/validation branch August 26, 2020 16:27
@github-actions github-actions bot modified the milestones: v0.1.0, v0.1.1 Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant