ENH: Add save functionality to _MonteCarloPlots.all method#884
Merged
Gui-FernandesBR merged 4 commits intodevelopfrom Nov 27, 2025
Merged
Conversation
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add save functionality to MonteCarloPlots.all method
ENH: Add save functionality to _MonteCarloPlots.all method
Nov 27, 2025
Member
|
@copilot please add this PR to the CHANGELOG.md file! |
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #884 +/- ##
===========================================
+ Coverage 80.27% 80.37% +0.09%
===========================================
Files 104 106 +2
Lines 12769 13007 +238
===========================================
+ Hits 10250 10454 +204
- Misses 2519 2553 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
_MonteCarloPlots.all()can only display histograms interactively. No option to save to disk, unlikeellipses(save=True)and other plot methods in RocketPy that supportfilenameparameter.New behavior
Added
filenameparameter to_MonteCarloPlots.all()following the established pattern used in_FlightPlots:show_or_save_plot()helper for consistent behaviorhistogram.png→histogram_apogee.png)Breaking change
Additional information
Closes #761
Also refactored
_post_test_file_cleanup()in test file to use list-based approach for maintainability.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.