Skip to content

Conversation

@phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Lint (make format) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

sweep length and sweep_angle were erroneously not included in the minimal encoding of TrapezoidalFins, causing fins that customize these parameters have incorrect decoding.

New behavior

The parameters were added to the encoding and are handled on decode. Tests were introduced to validate the desired values.

Breaking change

  • Yes
  • No

@phmbressan phmbressan added this to the Release v1.X.0 milestone Oct 25, 2025
@phmbressan phmbressan self-assigned this Oct 25, 2025
@phmbressan phmbressan added the Bug Something isn't working label Oct 25, 2025
@phmbressan phmbressan requested a review from a team as a code owner October 25, 2025 20:29
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.27%. Comparing base (20dc3be) to head (79a7923).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #861   +/-   ##
========================================
  Coverage    80.26%   80.27%           
========================================
  Files          104      104           
  Lines        12767    12768    +1     
========================================
+ Hits         10248    10249    +1     
  Misses        2519     2519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

Status: Next Version

Development

Successfully merging this pull request may close these issues.

2 participants