Bug: do not allow drawing rockets with no aerodynamic surface #774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
See #766,
When calling rocket.all_info() on a "surfaceless rocket", it throw an error.
New behavior
Now you will see no more errors when trying to print out information from a rocket without aero surfaces.
Breaking change
Additional information
I tested with the getting started notebook. Everything is looking fine.
Essentially: if you do not define any aerodynamic surface, why in the world would you want to draw the rocket? Sorry but we can't.