Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Place filename save parameter to the end. #739

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

New behavior

As described by the conversation in #731 , this PR moves the filename parameter to the end so as to avoid potential future breaking changes.

Breaking change

  • Yes
  • No

@phmbressan phmbressan added this to the Release v1.X.0 milestone Nov 29, 2024
@phmbressan phmbressan self-assigned this Nov 29, 2024
@phmbressan phmbressan requested a review from a team as a code owner November 29, 2024 21:49
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (e1a2061) to head (e723768).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #739      +/-   ##
===========================================
- Coverage    75.99%   75.97%   -0.02%     
===========================================
  Files           95       95              
  Lines        11015    11027      +12     
===========================================
+ Hits          8371     8378       +7     
- Misses        2644     2649       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Gui-FernandesBR Gui-FernandesBR merged commit a1709f9 into develop Nov 30, 2024
7 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/move-saveplots-args branch November 30, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants