ENH: add structural to total mass ratio for motor and rocket#713
Merged
Gui-FernandesBR merged 10 commits intodevelopfrom Nov 7, 2024
Merged
ENH: add structural to total mass ratio for motor and rocket#713Gui-FernandesBR merged 10 commits intodevelopfrom
Gui-FernandesBR merged 10 commits intodevelopfrom
Conversation
Lucas-Prates
added
the
Outputs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #713 +/- ##
===========================================
+ Coverage 75.88% 75.96% +0.07%
===========================================
Files 99 99
Lines 11222 11258 +36
===========================================
+ Hits 8516 8552 +36
Misses 2706 2706 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Made the suggested changes. The PR is ready for review again! |
Gui-FernandesBR
approved these changes
Nov 1, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
one last thing, @Lucas-Prates please update the CHANGELOG
Gui-FernandesBR
force-pushed
the
enh/add_dry_mass_total_mass_ratio
branch
from
b5a4f61 to
fc3013f
Compare
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Gui-FernandesBR
force-pushed
the
enh/add_dry_mass_total_mass_ratio
branch
from
fc3013f to
234e10d
Compare
Gui-FernandesBR
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyNew behavior
Solves issue #671 .
Breaking change
Additional information
From what I understood from the issue, the information required to be printed was the the ratio of the dry mass by the total mass. I saw some sources computing the propellant mass ratio, which I believe is the opposite (inverse of the specified ratio).