BUG: Fix Environment.max_expected_height for custom atmosphere
#707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
force-pushed
the
bug/fix-env-max-expected-height
branch
from
5093a70 to
2b51d10
Compare
Gui-FernandesBR
force-pushed
the
bug/fix-env-max-expected-height
branch
from
538617a to
6fe9b7c
Compare
Gui-FernandesBR
force-pushed
the
bug/fix-env-max-expected-height
branch
from
38590a0 to
20dd98a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #707 +/- ##
===========================================
- Coverage 76.02% 75.90% -0.12%
===========================================
Files 99 99
Lines 11278 11222 -56
===========================================
- Hits 8574 8518 -56
Misses 2704 2704 ☔ View full report in Codecov by Sentry. |
|
All tests, including slow tests, are passing locally. |
Gui-FernandesBR
commented
Oct 9, 2024
| @@ -1390,7 +1390,7 @@ def process_custom_atmosphere( | |||
| None | |||
| """ | |||
| # Initialize an estimate of the maximum expected atmospheric model height | |||
| max_expected_height = 1000 | |||
| max_expected_height = self.max_expected_height or 1000 | |||
There was a problem hiding this comment.
this line solves the issue
…RocketPy-Team/RocketPy into bug/fix-env-max-expected-height
…RocketPy-Team/RocketPy into bug/fix-env-max-expected-height
…RocketPy-Team/RocketPy into bug/fix-env-max-expected-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Enter text here...
New behavior
Enter text here...
Breaking change
Additional information
Enter text here...