Skip to content

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • ReadMe, Docs and GitHub updates

Checklist

  • CHANGELOG.md has been updated (if relevant)

Current behavior

The documentation requirements had windows only related dependencies.

New behavior

The docs requirements were generated on a linux machine to mirror ReadTheDocs build process.

Breaking change

  • Yes
  • No

Additional information

The docs requirements seem to be fixed, but I could not build them locally due to these lines keep going forever:

executing compare_flights user/compare_flights
curl error details: 

I don't know if this is a transitory server issue or something on our side @Gui-FernandesBR .

@phmbressan phmbressan added the Docs Docs and examples related label Aug 6, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Aug 6, 2024
@phmbressan phmbressan self-assigned this Aug 6, 2024
@phmbressan phmbressan requested a review from a team as a code owner August 6, 2024 12:05
@Gui-FernandesBR
Copy link
Member

Working fine on both read the docs and local machine.

cd docs
make clean

@Gui-FernandesBR Gui-FernandesBR merged commit 43a4aa3 into develop Aug 11, 2024
1 check passed
@Gui-FernandesBR Gui-FernandesBR deleted the doc/fix-docs-requirements branch August 11, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Docs and examples related
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants