Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: adding rocket radius to RailButtons class #643

Merged

Conversation

juliomachad0
Copy link
Member

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

A small change (addition of the rocket_radius attribute) was made to the RailButtons class to resolve issue #606. For the change to work in practical simulations, small changes were made to the rocket.py (add_surfaces method) and flight.py (u_dot_generalized method) files.

New behavior

It is now possible to use the RailButtons class in the way the user tried, without major changes to the code and with everything apparently working.

Breaking change

  • No

@juliomachad0 juliomachad0 added the Bug Something isn't working label Jul 19, 2024
@juliomachad0 juliomachad0 self-assigned this Jul 19, 2024
@juliomachad0 juliomachad0 requested a review from a team as a code owner July 19, 2024 22:03
@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop July 19, 2024 22:11
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.69%. Comparing base (d977fbe) to head (ad67701).

Files Patch % Lines
rocketpy/rocket/rocket.py 33.33% 4 Missing ⚠️
rocketpy/simulation/flight.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #643      +/-   ##
===========================================
- Coverage    75.72%   75.69%   -0.03%     
===========================================
  Files           81       81              
  Lines         9815     9823       +8     
===========================================
+ Hits          7432     7436       +4     
- Misses        2383     2387       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phmbressan phmbressan added Enhancement New feature or request, including adjustments in current codes and removed Bug Something isn't working labels Jul 19, 2024
@Gui-FernandesBR Gui-FernandesBR changed the title Enh/adding rocket radius to railbuttons class ENH: adding rocket radius to railbuttons class Jul 20, 2024
@Gui-FernandesBR Gui-FernandesBR linked an issue Jul 20, 2024 that may be closed by this pull request
@Gui-FernandesBR Gui-FernandesBR changed the title ENH: adding rocket radius to railbuttons class ENH: adding rocket radius to RailButtons class Jul 20, 2024
@Gui-FernandesBR Gui-FernandesBR removed the request for review from lucasfourier July 20, 2024 21:21
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @juliomachad0 !!

@Gui-FernandesBR Gui-FernandesBR force-pushed the enh/adding_rocket_radius_to_railbuttons_class branch from aeef806 to 56dd912 Compare July 20, 2024 22:21
@Gui-FernandesBR Gui-FernandesBR merged commit a901b45 into develop Jul 20, 2024
7 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the enh/adding_rocket_radius_to_railbuttons_class branch July 20, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

BUG: RailButtons does not have rocket_radius attribute
3 participants