-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: adding rocket radius to RailButtons class #643
ENH: adding rocket radius to RailButtons class #643
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #643 +/- ##
===========================================
- Coverage 75.72% 75.69% -0.03%
===========================================
Files 81 81
Lines 9815 9823 +8
===========================================
+ Hits 7432 7436 +4
- Misses 2383 2387 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @juliomachad0 !!
…ket_radius attribute to the RailButtons class). Improvement of the Railbuttons class.
aeef806
to
56dd912
Compare
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCurrent behavior
A small change (addition of the rocket_radius attribute) was made to the RailButtons class to resolve issue #606. For the change to work in practical simulations, small changes were made to the rocket.py (add_surfaces method) and flight.py (u_dot_generalized method) files.
New behavior
It is now possible to use the RailButtons class in the way the user tried, without major changes to the code and with everything apparently working.
Breaking change