Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: setting up vscode workspace #633

Merged
merged 6 commits into from
Jul 12, 2024
Merged

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Jul 6, 2024

Pull request type

  • Other (please describe): development tool!

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Most of our developers use Visual Studio Code as their development workspace.
However, VScode allows you to change several configurations, which may be a challenge for new developers.
It would be nice if we standardize some of basic configurations across the team.

New behavior

  • Removed vscode files from the gitignore (please check if it doesn't conflict with you local file!!
  • Added custom words to the cSpell dictionary (in the future I want to add a simple test that checks for typos, so it is important that we actually maintain this dictionary)
  • Added recommended extensions (as the name said, it is only a recommendation, so it won't be installed when cloning the repo).
  • I fixed some simple "typos" but didn't spend much time on that. This is something we can

These configurations will be used symbiotically along with your "user settings", therefore no conflicts or errors should be expected. It's just a matter of "guiding" new devs with useful recommendations.

Breaking change

  • No

Additional information

This is another step on the "making developers' lives easier" journey.

Refs:

@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner July 6, 2024 17:15
@Gui-FernandesBR Gui-FernandesBR force-pushed the dev/setting-up-vscode branch from 9fb479b to b812881 Compare July 6, 2024 17:16
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.85%. Comparing base (44cd770) to head (4de2918).
Report is 1 commits behind head on develop.

Files Patch % Lines
rocketpy/mathutils/function.py 0.00% 1 Missing ⚠️
rocketpy/simulation/monte_carlo.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #633   +/-   ##
========================================
  Coverage    73.85%   73.85%           
========================================
  Files           70       70           
  Lines        10035    10035           
========================================
  Hits          7411     7411           
  Misses        2624     2624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR force-pushed the dev/setting-up-vscode branch from b812881 to 4eedbd2 Compare July 9, 2024 15:53
@Lucas-Prates
Copy link
Contributor

Very good PR, certainly helps a lot to have uniform tools across the team! One thing, though: do you also have custom configurations for black/flake8? I recall someone suggesting flake8 args, but I forgot it 😬.

@Gui-FernandesBR
Copy link
Member Author

Very good PR, certainly helps a lot to have uniform tools across the team! One thing, though: do you also have custom configurations for black/flake8? I recall someone suggesting flake8 args, but I forgot it 😬.

@Lucas-Prates Thank you for your comment!

The customized pylint rules are defined in the .pylintrc file, in the root directory.
The black, isort and flake8 configurations are already done in the pyproject.toml file.
Therefore you should no longer be concerned with customizing these tools when working in this repository.

@Gui-FernandesBR
Copy link
Member Author

Requesting re-review from you @MateusStano @Lucas-Prates .
I'm assuming you've checked out the branch and tested in your machine without any conflicts.

Once again... recommendations are simply recommendations. If you don't want to use a certain extension, you just don't download it.

Copy link
Member

@MateusStano MateusStano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

I noticed that the spell checker does not analyze notebooks unless you open them, so there are a few words there that are not included in the exceptions.

I don't know if you intended notebooks to be included in the checking though, so I am approving the PR here

@Gui-FernandesBR Gui-FernandesBR merged commit 2defa9a into develop Jul 12, 2024
9 of 10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the dev/setting-up-vscode branch July 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants