-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: setting up vscode workspace #633
Conversation
9fb479b
to
b812881
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #633 +/- ##
========================================
Coverage 73.85% 73.85%
========================================
Files 70 70
Lines 10035 10035
========================================
Hits 7411 7411
Misses 2624 2624 ☔ View full report in Codecov by Sentry. |
b812881
to
4eedbd2
Compare
Very good PR, certainly helps a lot to have uniform tools across the team! One thing, though: do you also have custom configurations for black/flake8? I recall someone suggesting flake8 args, but I forgot it 😬. |
@Lucas-Prates Thank you for your comment! The customized pylint rules are defined in the .pylintrc file, in the root directory. |
Requesting re-review from you @MateusStano @Lucas-Prates . Once again... recommendations are simply recommendations. If you don't want to use a certain extension, you just don't download it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good
I noticed that the spell checker does not analyze notebooks unless you open them, so there are a few words there that are not included in the exceptions.
I don't know if you intended notebooks to be included in the checking though, so I am approving the PR here
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest tests -m slow --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Most of our developers use Visual Studio Code as their development workspace.
However, VScode allows you to change several configurations, which may be a challenge for new developers.
It would be nice if we standardize some of basic configurations across the team.
New behavior
cSpell
dictionary (in the future I want to add a simple test that checks for typos, so it is important that we actually maintain this dictionary)These configurations will be used symbiotically along with your "user settings", therefore no conflicts or errors should be expected. It's just a matter of "guiding" new devs with useful recommendations.
Breaking change
Additional information
This is another step on the "making developers' lives easier" journey.
Refs: